search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

bump ark to 0.9.0 #64

Closed stefan-pdx closed 9 years ago

stefan-pdx commented 9 years ago

This updates the ark dependency up to v0.9.0. See my comment here about how win_install_dir wasn't added to ark until v0.9.0. As a result, users who run this cookbook may see the issue outlined in #54.

chef-supermarket commented 9 years ago

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

chef-supermarket commented 9 years ago

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

jeffbyrnes commented 9 years ago

@slnovak since the pin is '~> 0.4', if you berks install (or berks update) you should end up with the most recent 0.x release of the ark cookbook. So this pin doesn’t prevent any version of ark save 1.0.0 & greater from being used.

tas50 commented 9 years ago

@slnovak I'm in agreement with @jeffbyrnes on this change. The current string will pull in ark 0.9.0 while still maintaining compatibility with wrapper cookbooks that may pin to an earlier version. This is the ideal setup until there's a compelling reason to force users to the latest and greatest version.