Rewrites the cookbook to adhere to best practices.

sous-chefs / maven

Development repository for the maven cookbook

https://supermarket.chef.io/cookbooks/maven

Apache License 2.0

36 stars 153 forks source link

Rewrites the cookbook to adhere to best practices. #67

Closed johnbellone closed 8 years ago

johnbellone commented 9 years ago

/cc @someara @acaiafa This is a complete rewrite of the Maven cookbook which brings it up to best practices. It does bump a whole major release because of some backwards incompatible changes such as deprecating the Maven 2.0 usage since it is now EOL. There is also a change in name for the resource which manages maven artifacts.

jeffbyrnes commented 9 years ago

@johnbellone we meet again! Came poking around here looking to see if there might be an outstanding PR or issue to cover tweaking the maven resource to not always report updated_by_last_action(true), which is causing some pain in a cookbook of ours.

Seems like this code would do it, but damn, lots of refactoring (and some strong opinions, not that that’s a bad thing).

Made a few comments to help get this merged in, maybe.

johnbellone commented 9 years ago

/cc @tas50

johnbellone commented 8 years ago

/cc @tas50 Should I bother rebasing and fixing? Any thoughts?

johnbellone commented 8 years ago

/cc @pburkholder @tas50

johnbellone commented 8 years ago

I am willing to rebase and make any changes that are necessary here. Its probably a new major version. If not interested then I'll close this off and push it up as a different name.

johnbellone commented 8 years ago

I'll work on #74 if that's alright with @tas50. I'll include the artifact and execute LWRP.