search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

Add support for maven-dependency-plugin 3.0.0, add version range support #80

Open jcam opened 7 years ago

jcam commented 7 years ago

Cookbook version

All

Chef-client version

12.2.1

Platform Details

Centos 6.7, Amazon EC2

Scenario:

I would like to be able to specify an artifact version range as [1.0.0,1.0.5] and also specify a target file name, and have the plugin automatically download the latest version in that range and call it that name. Maven Dependency Plugin version 3.0.0 added this support to the "get" goal, but the current cookbook uses version 2.4 of the plugin, and it still expects the version number to match what ends up in the filename. The above version range likely should not end up in a filename.

Steps to Reproduce:

Specify a version number like [1.0.0,1.0.5]

Expected Result:

Downloads the latest version in the range, setting the filename to the attribute specified

Actual Result:

The initial fetch fails, because dependency plugin 2.4 does not support a range

tas50 commented 7 years ago

I’m adding the Type: Jump In GitHub label to this issue. This is a great issue for someone to get their feet wet with and we’d love a PR to resolves the issue.