search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

Close file after write #84

Closed zamedic closed 7 years ago

zamedic commented 7 years ago

Description

Closes the file after it writes the settings file

Issues Resolved

https://github.com/chef-cookbooks/maven/issues/81 https://github.com/chef-cookbooks/maven/issues/77

Check List

[X ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD [X ] New functionality includes testing. [X ] New functionality has been documented in the README if applicable [X ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

zamedic commented 7 years ago

Hmmm - not sure how to rerun travis - looks like it timed out :(

tas50 commented 7 years ago

Thanks for the work here. In the future we have tooling that handles the version bump and the change log so that part isn't necessary

zamedic commented 7 years ago

thank you @tas50 - will keep that in mind.