search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

Make it possible to configure user/group to install Maven under #87

Closed jamietanna closed 6 years ago

jamietanna commented 6 years ago

Description

It was found in #82 that it is not possible to configure the user/group that Maven is installed under. This change makes that possible, and creates that user/group if required.

Additionally, this adds some more tests for the maven::default recipe.

Issues Resolved

Closes #82.

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD [x] New functionality includes testing. [x] New functionality has been documented in the README if applicable [x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

jamietanna commented 6 years ago

I haven't previously worked with Chef on Windows - would you mind helping me understand what would need to change to allow this to work better on Windows?

iennae commented 6 years ago

@jamietanna On windows systems for example there is no concept of a "root" user.

tas50 commented 6 years ago

@jamietanna If you want to refactor this in a way that doesn't break Windows we'd be more than happy to merge it in, but as it stands right now this removes Windows support for the cookbook. I'm going to close it out, but feel free to open this back up with the Windows support resolved.