search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

Update default maven version and checksum. #93

Closed alexanderdavidpan closed 6 years ago

alexanderdavidpan commented 6 years ago

Description

This fixes an error where the url returns a 404 for the maven tar file.

Issues Resolved

https://github.com/chef-cookbooks/maven/issues/92

Check List

[✅] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD [ ] New functionality includes testing. [✅] New functionality has been documented in the README if applicable (not applicable) [✅] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

iennae commented 6 years ago

@alexanderdavidpan Thanks for the PR. Could you amend your commit and sign it with -s to comply with DCO? Thank you!

alexanderdavidpan commented 6 years ago

@iennae I signed off on my commit. Thanks.

tas50 commented 6 years ago

This is going to be problematic in the long run. As apache moves the project off the main site this will be a 404. We need to pull from archive since those don't cycle off

alexanderdavidpan commented 6 years ago

@tas50, Good point. I reverted the maven url to point to Apache archives.

iennae commented 6 years ago

Good catch @tas50. Thanks for updating @alexanderdavidpan