search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

Setting maven group on mac downgrades admin users #97

Closed taylor-benson closed 4 years ago

taylor-benson commented 5 years ago

Cookbook version

5.2.0

Chef-client version

14.6.47

Platform Details

mac-os-x

Scenario:

There is no root group on MacOSX. So the ark install fails. If you set the attribute['maven']['group'] = 'admin' on the mac node, the user that had admin before gets reverted to a standard user.

I end up booting down to the single-user mode, removing the .AppleSetupDone to create a new admin user, then reset my user.

The chef client output shows 

 * group[create the group for Maven] action create[2018-12-05T15:31:59-06:00] INFO: Processing group[create the group for Maven] action create (maven::default line 25)
[2018-12-05T15:31:59-06:00] INFO: group[create the group for Maven] altered

    - alter group admin
    - replace group members with new list of members

Steps to Reproduce:

Set ['maven']['group'] = 'admin' on the mac node, run chef client. Any of your users that existed on the system who where admins get downgraded to standard users.

Expected Result:

Install maven and not loose admin privileges

Actual Result:

Install maven and keep admin privileges for the users that had admin.

welcomebot commented 5 years ago

Hey There It looks like this is the first issue you've filed against the chef-cookbooks project. I'm here to offer you a bit of extra help to make sure we can quickly get back to you. Make sure you've filled out all the fields in our issue template. Make sure you've provided us with the version of chef-client you're running, your operating system and the version of the cookbook. If you're not using the most up to date version of the cookbook then please make sure to update first. Lots of things change between versions even if you're issue isn't listed in the changelog. Finally please give us a detailed description of the issue you're having. The more we know about what you're trying to do, what actually happens, and how you can reproduce the problem, the better.

If you're looking for more immediate troubleshooting help make sure to check out #general on the Chef Community Slack. There's plenty of folks there willing to lend a helping hand. Thanks for the first issue. We hope we can get back to you soon with a solution.

taylor-benson commented 5 years ago

I see that you guys don't officially have macOSX on the supported platforms, but with this change locally the mac installs work. The other option is just to depend on homebrew and do brew install for the maven instead of ark, or better yet set the ['maven']['group'] = 'staff' and it does remove the users from admin. Anyways you guys can take this PR or maybe just update the doc for others so they don't get into the same situation.

github-actions[bot] commented 4 years ago

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

github-actions[bot] commented 4 years ago

Closing due to inactivity. If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.