search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

admin is the default admin group on macOSX #98

Closed taylor-benson closed 3 years ago

taylor-benson commented 5 years ago

Description

Fixes https://github.com/chef-cookbooks/maven/issues/97

Issues Resolved

https://github.com/chef-cookbooks/maven/issues/97

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD [ ] New functionality includes testing. [ ] New functionality has been documented in the README if applicable [ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

taylor-benson commented 5 years ago

@tas50 I will try wheel when I get home. The main issue I saw was if setting maven group to admin, I would lose the admin of my users who where admins. Ill report back soon.

taylor-benson commented 5 years ago

I think if you see the output in my issue of the run it says "replace group members with new list of members" but in the recipe, there is no members defined and replaces with a blank list?

taylor-benson commented 5 years ago

@tas50 I have tried "wheel" for the group and I don't loose my privileges. So that seems to work. However I just created a new user as an admin just to test out what group they are in and they only show in the admin group, not the wheel group, first one showed my admin account users, wheel did not

dscacheutil -q group -a name admin dscacheutil -q group -a name wheel

That being said, I can update the PR to 'wheel' if you prefer. Or if you guys just want to update the document for mac users to use anything but 'admin' for the ['maven']['group'] attribute

xorima commented 3 years ago

Closing due to inactivity.

If this is still wanted please reopen or open another pull request. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!

Thanks, Sous-Chefs