search

sous-chefs / mysql

Development repository for the mysql cookbook
https://supermarket.chef.io/cookbooks/mysql
Apache License 2.0
338 stars 690 forks source link

Renaming .kitchen.docker.yml to .kitchen.dokken.yml #504

Closed someara closed 7 years ago

someara commented 7 years ago

PLEASE STOP RENAMING THIS to .kitchen.docker.yml.

1) They are two completely different plugins. Having a naming mismatch creates confusion.

2) From the kitchen-dokken README under USAGE:

Add the following to your ~/.bash_profile
  export KITCHEN_YAML=.kitchen.yml
  export KITCHEN_LOCAL_YAML=.kitchen.dokken.yml

3) With the above settings, if you cd into a cookbook with a .kitchen.dokkken.yml, it will automatically pick up and use the dokken config. Otherwise it defaults to Vagarnt.

4) Doing "cd mysql ; kitchen verify smoke -c" explodes laptops under Vagrant.

Signed-off-by: Sean OMeara sean@sean.io

iennae commented 7 years ago

After discussions with folks in the cookbook-engineering channel we decided on standardizing on the .kitchen.DRIVER.yml configuration. There were conflicts on your PR so I went ahead and just updated the changes. Thanks @someara.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.