This PR contains the results of a cookstyle -a on the repo, this repo has been identified as a cookbook repo by topics of chef-cookbook
Changes
Cookstyle Fixes
Issues found and resolved with libraries/mysql_client_installation_package.rb
14:47 refactor: ChefRedundantCode/StringPropertyWithNilDefault - Properties have a nil value by default so there is no need to set the default value to nil.
Issues found and resolved with libraries/mysql_server_installation_package.rb
9:47 refactor: ChefRedundantCode/StringPropertyWithNilDefault - Properties have a nil value by default so there is no need to set the default value to nil.
Issues found and resolved with libraries/mysql_service.rb
15:47 refactor: ChefRedundantCode/StringPropertyWithNilDefault - Properties have a nil value by default so there is no need to set the default value to nil.
Issues found and resolved with spec/mysql_client_installation_package_spec.rb
6:48 refactor: ChefDeprecations/DeprecatedChefSpecPlatform - Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3
7:46 refactor: ChefDeprecations/DeprecatedChefSpecPlatform - Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3
Issues found and resolved with spec/mysql_server_installation_package_spec.rb
6:48 refactor: ChefDeprecations/DeprecatedChefSpecPlatform - Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3
7:46 refactor: ChefDeprecations/DeprecatedChefSpecPlatform - Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3
Issues found and resolved with test/cookbooks/test/recipes/installation_server.rb
5:17 refactor: ChefStyle/UsePlatformHelpers - Use platform? and platform_family? helpers to check a node's platform
This PR contains the results of a
cookstyle -a
on the repo, this repo has been identified as a cookbook repo by topics of chef-cookbookChanges
Cookstyle Fixes
Issues found and resolved with libraries/mysql_client_installation_package.rb
ChefRedundantCode/StringPropertyWithNilDefault
- Properties have a nil value by default so there is no need to set the default value to nil.Issues found and resolved with libraries/mysql_server_installation_package.rb
ChefRedundantCode/StringPropertyWithNilDefault
- Properties have a nil value by default so there is no need to set the default value to nil.Issues found and resolved with libraries/mysql_service.rb
ChefRedundantCode/StringPropertyWithNilDefault
- Properties have a nil value by default so there is no need to set the default value to nil.Issues found and resolved with spec/mysql_client_installation_package_spec.rb
ChefDeprecations/DeprecatedChefSpecPlatform
- Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3ChefDeprecations/DeprecatedChefSpecPlatform
- Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3Issues found and resolved with spec/mysql_server_installation_package_spec.rb
ChefDeprecations/DeprecatedChefSpecPlatform
- Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3ChefDeprecations/DeprecatedChefSpecPlatform
- Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3Issues found and resolved with test/cookbooks/test/recipes/installation_server.rb
ChefStyle/UsePlatformHelpers
- Use platform? and platform_family? helpers to check a node's platform