sous-chefs / nginx

Development repository for the nginx cookbook
https://supermarket.chef.io/cookbooks/nginx
Apache License 2.0
553 stars 806 forks source link

install from source recompiles every time #437

Closed ptimlum closed 6 years ago

ptimlum commented 7 years ago

Cookbook version

7.0.0

Chef-client version

12.5.1, 12.9.41, 12.11.18

Platform Details

CentOS 7.4

Scenario:

install from source tarball (versions tried 1.7.9, 1.12.1), chef rebuilds and restarts nginx every time.

Steps to Reproduce:

cookbook generates nginx

/opt/nginx-1.12.1/sbin/nginx -V
nginx version: nginx/1.12.1
built by gcc 4.8.5 20150623 (Red Hat 4.8.5-11) (GCC) 
built with OpenSSL 1.0.1e-fips 11 Feb 2013
TLS SNI support enabled
configure arguments: --prefix=/opt/nginx-1.12.1 --conf-path=/etc/nginx/nginx.conf --sbin-path=/opt/nginx-1.12.1/sbin/nginx --with-cc-opt=-Wno-error --with-http_ssl_module --with-http_gzip_static_module --with-http_stub_status_module

I think configure is stripping the quotes from -Wno-error compare of "--with-cc-opt=-Wno-error" to "--with-cc-opt=\"-Wno-error\"" triggers a rebuild

Expected Result:

configure; make; make install should have been skipped with with version and configure flags matching. should not restart.

Actual Result:

nginx rebuilds and restarts every time chef-client run. The quotes around -Wno-error don't seem to be needed.

ptimlum commented 6 years ago

Looks to be fixed by https://github.com/chef-cookbooks/nginx/commit/60d3b0984838857f56e420fabd91a2aa5604191d

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.