search

sous-chefs / nginx

Development repository for the nginx cookbook
https://supermarket.chef.io/cookbooks/nginx
Apache License 2.0
553 stars 806 forks source link

Cookbook readme indicates that configure_flags is deprecated but it is used in nginx.conf.erb template #463

Closed virtuman closed 5 years ago

virtuman commented 6 years ago

Cookbook version

8.1.5

Chef-client version

12.x

Platform Details

centos baremetal

Scenario:

nginx.conf.erb depends on deprecated variable

deprecation notice can be found here: https://github.com/chef-cookbooks/nginx#nginxsource

and the line referencing deprecated variable: https://github.com/chef-cookbooks/nginx/blob/master/templates/default/nginx.conf.erb#L122

Steps to Reproduce:

Expected Result:

it should probably use ['default_configure_flags'].include? for proper behavior

damacus commented 5 years ago

This should be fixed in the latest release. If this isn't the case please reopen!

Thanks, Dan