search

sous-chefs / nginx

Development repository for the nginx cookbook
https://supermarket.chef.io/cookbooks/nginx
Apache License 2.0
553 stars 806 forks source link

Ensure apt-transport-https is on Debian/Ubuntu before apt_repository #473

Closed zakame closed 5 years ago

zakame commented 5 years ago

On some cases (particularly kitchen converges using bento or dokken images of Debian/Ubuntu,) the nginx::repo recipe fails because it configures an apt_repository that uses an HTTPS source (e.g. https://nginx.org/packages/debian). Users of this cookbook will have to add the apt-transport-https package before including nginx.

This change aims to remove this little pessimization by ensuring to converge apt_pacakge 'apt-transport-https' on Debian/Ubuntu before converging apt_repository for the upstream nginx repo.

zakame commented 5 years ago

Tests are failing, but currently match master's status at the moment. I think I can fix the upstream-repo and distro-packages suites here in this PR (and perhaps UNIT_AND_LINT suite,) but not so for the other suites.

damacus commented 5 years ago

If you can add a changelog entry for this we're good to go!

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.