sous-chefs / nginx

Development repository for the nginx cookbook

https://supermarket.chef.io/cookbooks/nginx

Apache License 2.0

553 stars 806 forks source link

487/boolean #488

Closed damacus closed 5 years ago

damacus commented 5 years ago

Description

Remove section in site resource that is deprecated

Issues Resolved

Fixes #487

Check List

[ ] All tests pass. See TESTING.md for details
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

kitchen-porter commented 5 years ago

	1 Warning
:warning:	This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

damacus commented 5 years ago

This totally borks the unit tests.

Those need to be restructured, to use the more modern form. 🤔

I think that we probably need to rethink this whole cookbook from ground up. And in the process rethink how (and what) we're doing unit testing.

xorima commented 5 years ago

How and what should we be doing in unit testing, I can bring across the apache2 tests but it's resource only, is that good enough for now and we just accept that recipes are going and we do not have tests for them at this moment in time?

damacus commented 5 years ago

Closing in favour of #492

damacus commented 5 years ago

The biggest reason have the apache tests are there are to help with developing the correct resources and libraries.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.