sous-chefs / nginx

Development repository for the nginx cookbook

https://supermarket.chef.io/cookbooks/nginx

Apache License 2.0

553 stars 806 forks source link

Update site.rb #500

Closed oscar123mendoza closed 5 years ago

oscar123mendoza commented 5 years ago

Description

Right now nxensite is not being installed before this resource is calling it

Issues Resolved

[List any existing issues this PR resolves]

Check List

[ ] All tests pass. See TESTING.md for details
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

damacus commented 5 years ago

Hey,

Thanks for the PR! What are you trying to achieve here? For reference for all the questions we would usually ask are covered in the pr template which you haven't yet filled in.

Thanks,Dan

damacus commented 5 years ago

Closing for now as I'm not understand why this is needed. Please reopen if this is still required

oscar123mendoza commented 5 years ago

@damacus This its pretty clear what I'm trying do from my description above. You are not creating the following templates under /usr/sbin/* so chef cannot converge. This functionality was previously here https://github.com/sous-chefs/nginx/blob/d3579b9034386d6f353e8210f1c1ecd374fb2bc4/resources/install.rb#L285-L299

nxensite
nxdissite
nxenstream
nxdisstream