Add the official OpenVPN apt repositori when running on a debian family system.

[maf23]

Description

Add the official OpenVPN apt repositori when running on a debian family system. This adds the stable version of the repository.

Issues Resolved

This fixes issue #131

Check List

• [x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD (complains about label etc)
• [ ] New functionality includes testing.
• [ ] New functionality has been documented in the README if applicable

[flaccid]

Looks ok in concept, but tests failing atm.

[flaccid]

Technically, does not pass each point in the check list.

[maf23]

Yes, I did not know to add the label and summary which it was complaining about.

[damacus]

Is there a CentOS repo?

[maf23]

No, not that I have seen https://community.openvpn.net/openvpn/wiki/OpenvpnSoftwareRepos

On Wed, Aug 29, 2018 at 11:05 AM, Dan Webb notifications@github.com wrote:

Is there a CentOS repo?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sous-chefs/openvpn/pull/132#issuecomment-416880837, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEHdci-2SXkqaHITCs2x_A9LHmc1DUcks5uVlk_gaJpZM4WQ9DS .

--

Martin Forssén

Director of Information Security

Recorded Future https://www.recordedfuture.com/

+46 760 252357

maf@recordedfuture.com

[damacus]

LGTM, over to you @flaccid

[flaccid]

Make it pass the checklist!

[josephholsten]

Dangerfile:26:1: C: Style/SignalException: Always use raise to signal exceptions.
fail 'Please provide a summary of your Pull Request.' if github.pr_body.length < 10
^^^^
Dangerfile:28:1: C: Style/SignalException: Always use raise to signal exceptions.
fail 'Please add labels to this Pull Request' if github.pr_labels.empty?
^^^^
Dangerfile:34:3: C: Style/SignalException: Always use raise to signal exceptions.
  fail 'Please include a [CHANGELOG](https://github.com/sous-chefs/line-cookbook/blob/master/CHANGELOG.md) entry.'
  ^^^^
resources/conf.rb:58:24: W: Lint/UnneededCopEnableDirective: Unnecessary enabling of Metrics/MethodLength.
      # rubocop:enable Metrics/MethodLength
                       ^^^^^^^^^^^^^^^^^^^^
recipes/users.rb:22:3: C: Style/RedundantReturn: Redundant return detected.
  return klass.is_a?(Class)
  ^^^^^^
recipes/users.rb:24:3: C: Style/RedundantReturn: Redundant return detected.
  return false
  ^^^^^^

[maf23]

I am not sure if I can help any more. I do not know where the summary needs to be entered. I do not have write access to the repository so I can not label the pull request. I have added a line to the CHANGELOG but probably did something wrong since it is still complaining.

[damacus]

Merging this one in, looks like Danger is complaining, and rubocop is arguing with Danger 👍

Thanks for your contribution!

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.