Closed xorima closed 5 years ago
1 Warning | |
---|---|
:warning: | This Pull Request is probably missing tests. |
Generated by :no_entry_sign: Danger
Ugh, sorry sorry sorry, did not mean to do that.
Ok, to explain: seemed like it’d be nice to have the integration tests running as well, and this PR looked like it was really close, so I tightened things up, dropped the modifications to the attribute defaults in favor of what is in .kitchen.yml
on master, brought back testing on fedora, and opened a new branch.
Sadly, I forgot that my rename-branch
alias does some way-too-fancy pushing to the remote, and thus is blew up the branch here.
Everything’s been restored, and this is re-opened b/c I’m not keen to go off & close people’s PRs like that.
Please see #143 for my rebuild of this PR, which may get the integration tests working on CircleCI (we’ll see).
Closing in favour of #143
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
This commit adds circle ci integration testing for all tests
Signed-off-by: Jason Field jason@avon-lea.co.uk
Description
[Describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves]
Check List