Install gpg package (#183)

sous-chefs / openvpn

Development repository for the openvpn cookbook

https://supermarket.chef.io/cookbooks/openvpn

Apache License 2.0

98 stars 160 forks source link

Install gpg package (#183) #184

Closed axl89 closed 3 years ago

axl89 commented 3 years ago

This package is required for apt-repo recipe to converge successfully.

Description

Installs the gpg package before adding the openvpn repository.

Issues Resolved

Fixes #183

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

kitchen-porter commented 3 years ago

	1 Warning
:warning:	This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

axl89 commented 3 years ago

This should do it, I've tested it locally with kitchen and works as expected. Should I modify CHANGELOG.md as well to comply with @kitchen-porter's request?

EDIT: Just saw Ubuntu breaking on CI, I'm fixing that.

EDIT 2: Fixed! :smile:

ramereth commented 3 years ago

This should do it, I've tested it locally with kitchen and works as expected. Should I modify CHANGELOG.md as well to comply with @kitchen-porter's request?

Yes please. Add an ## Unreleased and then an entry.

axl89 commented 3 years ago

Said and done, @ramereth :smiley: