sous-chefs / openvpn

Development repository for the openvpn cookbook
https://supermarket.chef.io/cookbooks/openvpn
Apache License 2.0
98 stars 160 forks source link

Make client settings match server settings and improve docs (#189) #190

Open jgitlin-p21 opened 3 years ago

jgitlin-p21 commented 3 years ago

Description

As described in issue #198, make settings in the client configs (E.G. auth, cipher, compress, etc) match their server counterparts. This eliminates warnings in the OpenVPN log about inconsistent option usage.

In addition, document how the openvpn_user resource works, including showing how additional configuration options can be added to client conf files (using additional_vars and cookbook_user_conf)

Signed-off-by: Josh Gitlin jgitlin@pinnacle21.com

Issues Resolved

https://github.com/sous-chefs/openvpn/issues/189

Check List

the-label-bot[bot] commented 3 years ago

Kind Prediction: docs Confidence: 0.998

Provide the bot with feedback using a :thumbsup: or :thumbsdown:!

the-label-bot[bot] commented 3 years ago

Size Prediction: medium Confidence: 0.999

Nice! This should be quick to review

Provide the bot with feedback using a :thumbsup: or :thumbsdown:!

jgitlin-p21 commented 3 years ago

New functionality includes testing

I did not write new tests because the openvpn_user resource does not appear to have any tests at all yet 😞 I can work on some, but I won't have bandwidth for a week or more.

jgitlin-p21 commented 3 years ago

Whoops, I broke it 😭 fixing now!

Stromweld commented 2 months ago

If this PR is still relevant please update to fix the failing test or please close this PR if not needed anymore.