search

sous-chefs / openvpn

Development repository for the openvpn cookbook
https://supermarket.chef.io/cookbooks/openvpn
Apache License 2.0
98 stars 160 forks source link

Rollup of all pull requests #40

Closed josegonzalez closed 9 years ago

josegonzalez commented 9 years ago

I also aim to fix all tests.

josegonzalez commented 9 years ago

35185c1 also closes #30 and closes #31

josegonzalez commented 9 years ago

There appears to be an error downloading the apt packages, though I cannot replicate it locally... @jtimberman any ideas?

harmon commented 9 years ago

While you are at it, can you add an ending quote here? https://github.com/xhost-cookbooks/openvpn/pull/40/files#diff-04c6e90faac2675aa89e2176d2eec7d8R112

I read the contribution guidelines, and didn't feel like signing up for an account just to fix a closing quote in the README.

jtimberman commented 9 years ago

@harmon fixing the quote falls under our obvious fix policy.

harmon commented 9 years ago

@jtimberman: Ahh, good to know! Thanks. I just setup a VPN server this weekend using this chef recipe, thanks for the hard work on this cookbook! It made my life much easier :)

jtimberman commented 9 years ago

@josegonzalez Thank you for the pull request. I noticed it wouldn't merge cleanly, especially after I had merged a couple other PRs. I've made updates that address test failures as well (bdc4309). I'll be going through the other PRs that are still outstanding in the coming week. I'm not sure what else is addressed by this, but you'll definitely need to update from master at least, and reconcile any other changes. If there's anything missing, please open a new PR.

Thanks for your help!

lock[bot] commented 6 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.