search

sous-chefs / packagecloud

Development repository for the packagecloud cookbook
https://supermarket.chef.io/cookbooks/packagecloud
Apache License 2.0
17 stars 48 forks source link

Make force_os/force_dist work properly with debian repos #41

Closed ctdk closed 7 years ago

ctdk commented 8 years ago

Fixes the issue mentioned in #40 where the force_os/force_dist options don't actually work for deb repos.

One note: in https://github.com/raintank/packagecloud-cookbook/commit/27080c1066869d564bcdc6cdeeee05d75a032774#diff-2bb89c3cb0524511e4c762ffc09cf060R21, one can see that the test installs a debian wheezy repo from computology/packagecloud-test-packages and installs packagecloud-test for debian wheezy. Since this does not actually currently exist in that repo it will fail (I had to test with a goiardi repo to make sure it worked, but it didn't seem appropriate for the PR). Someone over there will need to set that up.

yourivdlans commented 7 years ago

Would love to see this merged :) what do we need to get it merged?

ice799 commented 7 years ago

So I think perhaps a different test we could add instead of installing a package here would be to check the apt repo config against a regex or something, since that is essentially what we want to verify -- that the repo config was properly written out given a forced OS/dist.

ice799 commented 7 years ago

OK, I modified this slightly to use a different test and merged it. Thanks @ctdk for this PR. Closing this out now.