Drop support for building source on Debian 9

sous-chefs / php

Development repository for the php cookbook

https://supermarket.chef.io/cookbooks/php

Apache License 2.0

442 stars 490 forks source link

Drop support for building source on Debian 9 #302

Closed jeffbyrnes closed 4 years ago

jeffbyrnes commented 4 years ago

Description

Drops support for building PHP from source on Debian 9. It’s got some strange failures, and providing meaningful support for package install, and source support otherwise, is a sensible step forward.

Issues Resolved

None

Check List

[x] All tests pass. See TESTING.md for details.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable.

tas50 commented 4 years ago

I’m not really comfortable dropping support for either of these releases. EL 6 support going away is fine because that release is about to go away, but Debian 9 is pretty new and Ubuntu 16.04 is still very common

jeffbyrnes commented 4 years ago

@tas50 I’m having a hard time finding it, but somewhere someone suggested to me that we could drop testing/support? on Ubuntu 16.04.

Debian 9, I hear you, and I was banging away at trying to get it to work when building from source.

Maybe the halfway version is to support Debian 9 only via package install, and add a guard statement to early-out if someone tries to do a source install on that distro version?

The issue with it, far as I can tell, is that some of the libraries necessary are not seen by the configure script (e.g., curl, gmp, and maybe more).

ramereth commented 4 years ago

I’m not really comfortable dropping support for either of these releases. EL 6 support going away is fine because that release is about to go away, but Debian 9 is pretty new and Ubuntu 16.04 is still very common

I'm with @tas50 here, We shouldn't be dropping either yet as they're both still supported upstream and are used by many folks. Debian 9 is supported through mid-June 2022 and Ubuntu 16.04 standard EOL is not until April 2021.

Are there specific reasons for why you're needing to drop either?

jeffbyrnes commented 4 years ago

After a discussion in Slack in #sous-chefs, new plan:

Bring back package support for Ubuntu 16 & Deb 9
Set up an early-out for source installs on those versions

jeffbyrnes commented 4 years ago

@tas50, @damacus, this is testing great now!