sous-chefs / php

Development repository for the php cookbook
https://supermarket.chef.io/cookbooks/php
Apache License 2.0
444 stars 490 forks source link

Add community repos #314

Closed jeffbyrnes closed 3 years ago

jeffbyrnes commented 3 years ago

Description

Add ability to use community-supported repositories (PPA for Debian systems, custom RPM for Red Hat/Amazon) to install more recent versions of PHP.

Issues Resolved

Fixes #224

Check List

ramereth commented 3 years ago

@jeffbyrnes do you mind addressing the md-links test that's failing? It seems to be unrelated to your change but it would be nice to fix.

jeffbyrnes commented 3 years ago

@ramereth so here’s the thing: I tried to! But for some reason, those links always 503. If you visit the current ones in a browser, you’ll 301 → updated link, but even if I update the links to the result of the 301, md-links still says they're busted.

Maybe php.net has some kind of anti-robot setup that 503s non-human visitors?

jeffbyrnes commented 3 years ago

@ramereth added ecdc59ff90d05c22a6a118e9da5c7c3444c02132 to fix the links in the docs, let's see how it acts this time.

ramereth commented 3 years ago

@ramereth so here’s the thing: I tried to! But for some reason, those links always 503. If you visit the current ones in a browser, you’ll 301 → updated link, but even if I update the links to the result of the 301, md-links still says they're busted.

Maybe php.net has some kind of anti-robot setup that 503s non-human visitors?

Yeah, I wonder if they do. I'd vote to remove that specific check as I don't think we have it turned on globally. @sous-chefs/board thoughts? We mostly just need the MDL check.

jeffbyrnes commented 3 years ago

@ramereth well, other than md-links, things are looking green!

ramereth commented 3 years ago

@jeffbyrnes go ahead and remove that check in this PR so this will completely pass.

jeffbyrnes commented 3 years ago

Not sure why your commit didn’t show up @ramereth. I amended it slightly & force-pushed, it's here now.

ramereth commented 3 years ago

@jeffbyrnes yeah, GH being strange.. thanks

kitchen-porter commented 3 years ago

Released as: 8.1.0