sous-chefs / php

Development repository for the php cookbook
https://supermarket.chef.io/cookbooks/php
Apache License 2.0
443 stars 491 forks source link

chore: delay php-fpm service restart upon configuration update #365

Closed igolman closed 2 weeks ago

igolman commented 2 weeks ago

Description

This resolves unneeded subsequent restarts of phpX.Y-fpm service upon FPM pool configuration update. If more than 5 FPM pools are affected of a configuration change, systemd will fail to restart the service with following error:

php8.1-fpm.service: Start request repeated too quickly.
php8.1-fpm.service: Failed with result 'start-limit-hit'.
Failed to start The PHP 8.1 FastCGI Process Manager.

Although according to chef resource documentation the default value for the :timer is :delayed, it seems not to be the case and should be explicitly set. This behavior may be observed at the github's regressions tests

Issues Resolved

Check List

damacus commented 2 weeks ago

Nice simple change. Thanks for this.

If there are any unintended consequences like ordering. Let us know, and maybe we can make this configurable

kitchen-porter commented 2 weeks ago

Released as: 10.2.0