sous-chefs / powershell

Development repository for the powershell cookbook
https://supermarket.chef.io/cookbooks/powershell
Apache License 2.0
110 stars 88 forks source link

Fixed reboot not found in 2008R2 bug #111

Closed rschiefer closed 7 years ago

rschiefer commented 7 years ago

Description

Fixes a bug when leveraging the powershell5 recipe in Windows Server 2008R2.

Issues Resolved

https://github.com/chef-cookbooks/powershell/issues/110

Check List

stuartpreston commented 7 years ago

Hi @rschiefer thanks for this PR - please could you amend your commit to have a DCO sign-off?

rschiefer commented 7 years ago

Amended.

stuartpreston commented 7 years ago

+1 - thanks @rschiefer

smurawski commented 7 years ago

The PR looks good to me 👍 Just needs the DCO signoff.

fourth-barryleonard commented 7 years ago

Hi All,

Can we get this one merged and released please? We're currently seeing this issue as well and it looks like this is just being held up by a sign off issue. Happy to help in any way.

Cheers,

Barry

btm commented 7 years ago

Actually appveyor looks stuck or misconfigured. I'll look at it.

btm commented 7 years ago

Merged in #115 with test fixes.

fourth-barryleonard commented 7 years ago

thanks for the swift response @btm - I've just checked out the build log on appveyor but it looks like it failed?

btm commented 7 years ago

@fourth-barryleonard I fixed it over in #115. It passed there in https://ci.appveyor.com/project/ChefWindowsCookbooks/powershell/build/1.0.112

https://ci.appveyor.com/project/ChefWindowsCookbooks/powershell/build/1.0.113 looks like a transient network issue.

fourth-barryleonard commented 7 years ago

@btm thanks. We're testing against Azure now following the release. Cheers, Barry