sous-chefs / powershell

Development repository for the powershell cookbook
https://supermarket.chef.io/cookbooks/powershell
Apache License 2.0
110 stars 88 forks source link

Deprecation messsages from windows cookbook #149

Closed imchanhtin closed 1 year ago

imchanhtin commented 1 year ago

:ghost: Brief Description

The windows cookbook is EOL and this cookbook still depend on it. It will create some deprecation messages we run. Can we add a filter on depend part to remove the deprecation messages.

       Deprecation warnings that must be addressed before upgrading to Chef Infra 18:

         The  resource in the windows cookbook should declare `unified_mode true` at 5 locations:
           - C:/Users/ADMINI~1/AppData/Local/Temp/kitchen/cache/cookbooks/windows/resources/certificate_binding.rb
           - C:/Users/ADMINI~1/AppData/Local/Temp/kitchen/cache/cookbooks/windows/resources/dns.rb
           - C:/Users/ADMINI~1/AppData/Local/Temp/kitchen/cache/cookbooks/windows/resources/http_acl.rb
           - C:/Users/ADMINI~1/AppData/Local/Temp/kitchen/cache/cookbooks/windows/resources/schannel.rb
           - C:/Users/ADMINI~1/AppData/Local/Temp/kitchen/cache/cookbooks/windows/resources/zipfile.rb
          See https://docs.chef.io/deprecations_unified_mode/ for further details.

       Infra Phase complete, 8/10 resources updated in 01 minutes 23 seconds

:pancakes: Cookbook version

6.2.5

:woman_cook: Chef-Infra Version

Version of chef-client: 17.x & 18.x

:tophat: Platform details

Steps To Reproduce

Steps to reproduce the behavior:

Run chef-client with this cookbook on list above windows server

:police_car: Expected behavior

Add filter to only depend windows cookbook if chef version is older than 13. Example: depends 'windows', '>= 3.0' unless Chef::VERSION.to_f >= 14