search

sous-chefs / powershell

Development repository for the powershell cookbook
https://supermarket.chef.io/cookbooks/powershell
Apache License 2.0
110 stars 88 forks source link

remove deprecation warning #89

Closed mhorbul closed 8 years ago

mhorbul commented 8 years ago

Description

This PR removes deprecation warning introduced by this change in chef repo https://github.com/chef/chef/commit/97aaf5bbcdfd0810722b123bdc67e883a7ca8077

Issues Resolved

vinyar commented 8 years ago

ooo... i just filed a bug on this, gonna give it a spin right now

vinyar commented 8 years ago

so, i just gave it a spin (and learned that it's very difficult to find the origin of the PR (or that i suck at github.com)) Berksfile:

source 'https://supermarket.chef.io'
cookbook 'powershell', git: 'https://github.com/eligible/powershell.git', ref: 'c0e1f8bbfc7adc7464e7cc321572dbb84fdb1341'
metadata

Warning (assuming that's the one you fixed) is still there:

       Deprecated features used!
         Using an LWRP provider by its name (WindowsFeatureDism) directly is no longer supported in Chef 12 and will be removed.  Use Chef::ProviderResolver.new(node, resource, action) instead. at 1 location:
           - C:\Users\vagrant\AppData\Local\Temp\kitchen\cookbooks\windows\resources\feature.rb:32:in `initialize'

       Chef Client finished, 0/1 resources updated in 03 seconds
       Finished converging <certification-wind2012-r2> (0m9.37s).
-----> Kitchen is finished. (0m11.90s)
mhorbul commented 8 years ago

The Warning which is fixed by this PR is the following 

  The on_platforms option to node_map has been deprecated at 1 location:
    - /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef.rb:20:in `log_deprecation'
smurawski commented 8 years ago

closes #90

vinyar commented 8 years ago

i didnt even realize the error was from windows cookbook @mhorbul 2am comments on github will do that 👍 thanks for the PR