Any reason why the redis.conf template does not notify the service to restart?

[ismailfaruqi]

Hi,

Just wondering why the redis.conf template does not notify the service to restart? Any particular reason for this decision?

Thanks!

[martinb3]

I joined the project after that was written, but a quick glance through the history suggests that feature has never been there. Restarting redis seems dangerous when sentinel is re-writing conf files at the same time as chef, so I know I wouldn't ever want restarting automatically, but perhaps it could be an option to turn it on.

[brianbianco]

This is pretty much the exact reason. Restarting redis can be a very dangerous operation so I never included that functionality. I did plan to provide the option to set it so that you could, however nobody really requested it so I never got around to it.

This is certainly something that can be added.

On Jul 31, 2015, at 4:40 AM, Martin Smith notifications@github.com wrote:

I joined the project after that was written, but a quick glance through the history suggests that feature has never been there. Restarting redis seems dangerous when sentinel is re-writing conf files at the same time as chef, so I know I wouldn't ever want restarting automatically, but perhaps it could be an option to turn it on.

— Reply to this email directly or view it on GitHub https://github.com/brianbianco/redisio/issues/220#issuecomment-126609836.

[spuder]

+1

The kafka cookbook has a pretty slick implementation that allows for rolling restarts (and prevents the entire cluster from rebooting at the same time)

[bpoweski]

I think an automatic restart as the default behavior is a bad idea. The main consequence from our perspective is that restarting a Redis instance will return a loading error while the dataset is being read from disk. We run 60GB nodes with SSDs and the disruption is noticeable noticeable therefore we try to minimize it. I presume this is a somewhat common requirement.

Making this the standard behavior essentially means any new cookbook upgrade will trigger a redis restart as the template file will likely be changed in each release. An opt in config option would be our preferred option.

[xorima]

Closing due to inactivity.

If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!

Thanks, Sous-Chefs

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.