sous-chefs / redisio

Development repository for the redisio cookbook
https://supermarket.chef.io/cookbooks/redisio
Apache License 2.0
297 stars 300 forks source link

Instead of writing breadcrumb files; leverage the action of :create_if_missing #347

Closed damm closed 5 years ago

damm commented 7 years ago

Based on our past conversations I won't bother submitting a PR for this.

Your cookbook uses action :create here https://github.com/brianbianco/redisio/blob/190a0e0bfb5190798e8aadfee1d1d63ba6218c31/providers/configure.rb#L228 and then later you drop the breadcrumb here https://github.com/brianbianco/redisio/blob/190a0e0bfb5190798e8aadfee1d1d63ba6218c31/providers/configure.rb#L301

Not what most people expect; and really a lot of people expect to be able to delete a configuration file and run chef and have it regenerated... this doesn't happen because the breadcrumb exists

josephholsten commented 5 years ago

Relevant to this issue: https://github.com/antirez/redis/issues/5226

xorima commented 5 years ago

Closing due to inactivity.

If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!

Thanks, Sous-Chefs

damm commented 5 years ago

Good thing I don't use this cookbook anymore because yeah it's a problem just the author took didn't care for seriously almost 2 years.

brianbianco commented 5 years ago

If only the author donated years of hard work then had other things to do and community members, instead of using energy solving the problem, do things like post comments like this.

This is the thanks people get for donating their time. Ask yourself, if this is the reward you received how much of your time would you donate?

damm commented 5 years ago

Been there done that; tried to offer help but it wasn't well received so I didn't bother helping you.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.