sous-chefs / redisio

Development repository for the redisio cookbook

https://supermarket.chef.io/cookbooks/redisio

Apache License 2.0

297 stars 301 forks source link

Make daemenize option configurable #403

Closed JanStevens closed 5 years ago

JanStevens commented 5 years ago

Description

I want to have an explicit daemonize configuration property so I can control the setting explicitly. I rather have systemd manage redis instead of redis managing itself. This also allows to write a pid file and allow to have other processes act with it

Issues Resolved

None really except my own

Check List

[ ] All tests pass. See TESTING.md for details.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

kitchen-porter commented 5 years ago

	1 Warning
:warning:	This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

JanStevens commented 5 years ago

Not needed at all: https://github.com/antirez/redis/pull/2266

Redis always writes a pid file

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.