sous-chefs / redisio

Development repository for the redisio cookbook
https://supermarket.chef.io/cookbooks/redisio
Apache License 2.0
297 stars 301 forks source link

redis.conf.erb version checks incorrectly on some sections #427

Closed jrobertotg closed 4 years ago

jrobertotg commented 4 years ago

:ghost: Brief Description

In the redis.conf.erb, there's a block designated for key space notifications and is to be included with redis versions 2.8 and higher:

https://github.com/sous-chefs/redisio/blob/master/templates/default/redis.conf.erb#L826

However, as per the conditional just above the block, it will only work on 2.8.x through 3.x.x, so when installing newer versions of the package, this block (and possibly others) will be excluded.

For example, we're installing redis version 5.0.5, and this block is completely excluded.

:pancakes: Cookbook version

4.1.0

:woman_cook: Chef-Infra Version

16.3.45

:tophat: Platform details

CentOS 7

:police_car: Expected behavior

The keyspace notification block should be properly included on all versions higher than 2.8