Automated PR: Cookstyle Changes - Githubissues

sous-chefs / redisio

Development repository for the redisio cookbook

https://supermarket.chef.io/cookbooks/redisio

Apache License 2.0

297 stars 301 forks source link

Automated PR: Cookstyle Changes #429

Closed xorimabot closed 4 years ago

xorimabot commented 4 years ago

Hey! I ran Cookstyle 6.16.4 against this repo and here are the results. This repo was selected due to the topics of chef-cookbook

Changes

Issues found and resolved with resources/configure.rb

20:1 refactor: ChefRedundantCode/CustomResourceWithAllowedActions - It is not necessary to set actions or allowed_actions in custom resources as Chef Infra Client determines these automatically from the set of all actions defined in the resource

Issues found and resolved with resources/install.rb

19:1 refactor: ChefRedundantCode/CustomResourceWithAllowedActions - It is not necessary to set actions or allowed_actions in custom resources as Chef Infra Client determines these automatically from the set of all actions defined in the resource

Issues found and resolved with resources/sentinel.rb

19:1 refactor: ChefRedundantCode/CustomResourceWithAllowedActions - It is not necessary to set actions or allowed_actions in custom resources as Chef Infra Client determines these automatically from the set of all actions defined in the resource

kitchen-porter commented 4 years ago

	1 Warning
:warning:	This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

tas50 commented 4 years ago

This is a cookstyle bug that I need to track down. This is a LWRP not a custom resource.

tas50 commented 4 years ago

Fixed in https://github.com/chef/cookstyle/pull/730