search

sous-chefs / redisio

Development repository for the redisio cookbook
https://supermarket.chef.io/cookbooks/redisio
Apache License 2.0
297 stars 300 forks source link

Chef 16+ user_ulimit warning message #432

Open kpmueller opened 4 years ago

kpmueller commented 4 years ago

:ghost: Brief Description

This bug report is not directly in the redisio cookbook, but a dependent cookbook. However, there is no way to resolve it in the dependent cookbook -- using it at all will create the warning.

The redisio cookbook includes the ulimit cookbook, which creates a user_ulimit resource. This resource is now part of Chef 16 as well. The Chef16 client complains about this resource being overridden with this warning:

[2020-09-19T23:26:21-07:00] WARN: Resource user_ulimit built into Chef Infra Client is being overridden by the resource from a cookbook. Please upgrade your cookbook or remove the cookbook from your run_list.

:pancakes: Cookbook version

Any version including the ulimit cookbook will produce this warning

:woman_cook: Chef-Infra Version

Any Chef client 16+ will produce this error, but I'm using 16.5.64

:tophat: Platform details

Ubuntu 18.04 in AWS

Steps To Reproduce

Including the redisio cookbook in any manner with a Chef 16+ client will produce this warning at the top, due to its inclusion of the ulimit cookbook as a dependency.

:police_car: Expected behavior

That no warning happens

:heavy_plus_sign: Additional context

As long as Chef versions older than 16 need to be supported, I could see this not being addressed or changed. (It would be annoying to create ulimits within the cookbook itself, after all)

Once Chef 16 becomes the minimum version, then using the native user_ulimit means the ulimit cookbook should no longer be necessary, and I think set directly with the native support?

ramereth commented 4 years ago

I think our plan is to support at minimum Chef 15 until it reaches it's end of life next year. Since this resource wasn't included until 16, we can't remove it until then.