sous-chefs / redisio

Development repository for the redisio cookbook
https://supermarket.chef.io/cookbooks/redisio
Apache License 2.0
297 stars 301 forks source link

add option to set aclfile #485

Closed simonasr closed 9 months ago

simonasr commented 10 months ago

Description

Adding aclfile option to Redis configuration file.

Issues Resolved

Enables configuring external ACL file for Redis v6+

Check List

xorima commented 9 months ago

Hey @simonasr

Thanks for this. Can you drop an update to the change log under the ## Unreleased section then I can get this shipped asap

simonasr commented 9 months ago

Hey @simonasr

Thanks for this. Can you drop an update to the change log under the ## Unreleased section then I can get this shipped asap

Thanks @xorima! Changelog updated.

kitchen-porter commented 9 months ago

Released as: 6.6.0

damacus commented 9 months ago

@simonasr do you want to take point on removing some of the older configuration options for redis?

Looks like we really only want to be supporting 6+ at a minimum

https://endoflife.date/redis

simonasr commented 9 months ago

@simonasr do you want to take point on removing some of the older configuration options for redis?

Looks like we really only want to be supporting 6+ at a minimum

https://endoflife.date/redis

Hi @damacus

Sure, I'd be happy to help with that in my free time. Just to be clear, are we talking about removing obsolete conditional statements from the configuration templates and related code if such, or is there more to it? As far as I know, Redis hasn't actually removed any configuration options, so I just want to understand the scope of what we're doing.

damacus commented 9 months ago

Yeah, pretty much want to make sure 6 and 7 work. It's easier if it's headed up by someone who still uses it