sous-chefs / redisio

Development repository for the redisio cookbook

https://supermarket.chef.io/cookbooks/redisio

Apache License 2.0

297 stars 301 forks source link

cleanup: remove support for EOL Redis versions #486

Closed simonasr closed 5 months ago

simonasr commented 9 months ago

Description

This PR updates Redis configuration to be compatible with version post to v6, following th end-of-life for older versions. Redis EOL: https://endoflife.date/redis Related discussion: https://github.com/sous-chefs/redisio/pull/485#issuecomment-1806862360

Issues Resolved

[x] Remove obsolete Redis version checks
[x] Remove deprecated Redis configuration options
[x] Update Redis docs in configuration template
[x] Update slave -> replica where applicable
[x] Remove redis-package test suite
[x] Bump Redis version used for tests
[x] Update CHANGELOG

Check List

[x] A summary of changes made is included in the CHANGELOG under ## Unreleased
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable.

xorima commented 9 months ago

Adding major as release version as we are removing stuff and version numbers are free.

simonasr commented 8 months ago

Hi @damacus, i'm a bit stuck here:

most Linux distributions provide Redis v4 package only, which does not work with "modern" Redis configurations. How could we proceed here - should we remove "redis-package" test suite from integration tests? 🤔

damacus commented 8 months ago

Yeah just remove the package test here

According to https://endoflife.date/redis we should only be testing 6.3, 7.0 and 7.2. Anything else isn't getting patched

damacus commented 8 months ago

Not for this cleanup PR, but it's easier to split out the documentation for each of the resources into their own file a la, java/apache2.

simonasr commented 6 months ago

Hi @damacus I've finalised the PR and believe it's now ready for review. Finding time to dedicate to this was more challenging than I initially thought. Could you please review it and share your feedback? Additionally, if further modifications or steps are needed, please guide me on how to proceed.

simonasr commented 5 months ago

Not a blocker but do we need an upgrading guideline for this? I.e you have today you need tomorrow kinda things

Thanks @xorima, do you have in mind something like example bellow? 🤔 should this go to the CHANGELOG?

Upgrade Guidelines:

Ensure all Redis instances are upgraded to version 6.2.14 or higher.

Update configuration files to reflect the terminology change from "slave" to "replica."

Remove any references to deprecated options like list-max-ziplist-entries and list-max-ziplist-value.

Test the compatibility of your Chef cookbook with Redis v6+ before deploying the upgrade.

xorima commented 5 months ago

I'm happy, but would like further review from @damacus or @ramereth ideally

sorry for missing your message @simonasr , the last few weeks have been full on.

kitchen-porter commented 5 months ago

Released as: 7.0.0

xorima commented 5 months ago

Shipped, sorry about that, our release system had a bad day ...