CH-#123 - RSYSLOG COOKBOOK :: Extending Attributes in lieu of hardcoded values

rmcleod8 commented 7 years ago

Description

Removes hardcoded values of $Umask, $FileCreateMode and $DirCreateMode. They can now be set using the attribute. Added attributes for $DirOwner, $DirGroup and $Templates. These can now be set using attributes.

Issues Resolved

https://github.com/chef-cookbooks/rsyslog/issues/123

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

johnbellone commented 7 years ago

/cc @tas50

dquiles commented 7 years ago

lgtm

rmcleod8 commented 7 years ago

@Argoday This change is correcting previously hardcoded and missing attributes which would atleast let the user to set them.

Argoday commented 7 years ago

@rmcleod8 - retracting my previous comment .. didn't pay enough attention to which repo this is

tas50 commented 7 years ago

Thanks for the fixes

sous-chefs / rsyslog