sous-chefs / rsyslog

Development repository for the rsyslog cookbook

https://supermarket.chef.io/cookbooks/rsyslog

Apache License 2.0

65 stars 199 forks source link

Fix default group and dir-group for RHEL-derived linux config #153

Open bish0polis opened 5 years ago

bish0polis commented 5 years ago

Description

This change fixes the issue in #152

Issues Resolved

152

Note

This patch is hereby public domain. I committed without standing on the left foot, or including the right magic legal statement, or whatever voodoo is required; and I don't have the gear to prove adequate testing. And after midnight the additional costs of donated labour start to become noticeable. :-/

caryp commented 5 years ago

@bish0polis thanks for the fix! can you pls fix code style violations so this may be merged?

xorima commented 3 years ago

Closing due to inactivity.

If this is still wanted please reopen or open another pull request. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!

Thanks, Sous-Chefs

bish0polis commented 3 years ago

It doesn't appear I can re-open it.

But if it sat for 20 months in a ready state, I don't know what re-opening's going to do.

xorima commented 3 years ago

Re-opening means there is still a desire for this feature, when we inherit cookbooks some older prs are no longer valid, this is a way of finding out features wanted/required vs features no longer wanted

bish0polis commented 3 years ago

Re-opening means there is still a desire for this feature

Neat. I couldn't find the bit on the UI that allowed for re-opening. Either I'm used to GL vs GH or an ACL prevented its inclusion.