Bug 119 too many imfiles

runswithd6s commented 4 years ago

In order use the rsyslog_file_input resource, $ModLoad imfile needs to be defined only once. Removed it from the file-input.conf.erb template file and added README.md instructions to add the imfile module to the node to enable. Added tests for a second log file and for existence of one module load statement.

Description

The file_input resource was incorrectly including the legacy $ModLoad imfile declaration in each new config file created from template. Additionally, the legacy style script prevented newer rsyslog daemons from using inotify method. This commit adds:

Legacy configuration file support
Ranier style configuration file support
Ability to specify imfile module parameters
Ability to specify additional resource parameters for rsyslog_file_input

Issues Resolved

Fixed #119.

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

runswithd6s commented 4 years ago

Re-based version.

runswithd6s commented 4 years ago

Tests for CentOS 6 are failing due to unrelated problem around imjournal configuration.

xorima commented 3 years ago

Hey @runswithd6s

Any chance you can rebase this?

Thanks!

ramereth commented 3 years ago

@Xorima any particular reason why this needs a major bump?

xorima commented 3 years ago

@Xorima any particular reason why this needs a major bump?

The imfile change could catch someone off guard, it's not a big change but let's not surprise people

kitchen-porter commented 3 years ago

Released as: 8.0.0

sous-chefs / rsyslog