sous-chefs / rsyslog

Development repository for the rsyslog cookbook

https://supermarket.chef.io/cookbooks/rsyslog

Apache License 2.0

65 stars 199 forks source link

Allow $MaxMessageSize to be omitted from configuration #197

Closed gmarler closed 1 year ago

gmarler commented 1 year ago

Update template to not emit $MaxMessageSize if attr is nil/false
Update README.md for attr that nil/false are now valid

Description

Allows specifying nil/false for node['rsyslog']['max_message_size'], so that $MaxMessageSize is not emitted into /etc/rsyslog.conf

Issues Resolved

https://github.com/sous-chefs/rsyslog/issues/196

Check List

[ ] A summary of changes made is included in the CHANGELOG under ## Unreleased
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

bmhughes commented 1 year ago

Thanks for the PR @gmarler!, could you add an entry in the CHANGELOG then we can get this merged.

gmarler commented 1 year ago

Working it...

gmarler commented 1 year ago

Oh, any particular place you'd like me to put a unit test for this?

xorima commented 1 year ago

It would be nice to have it set the var and see that the file would have been created with the value and another without. either chefspec or inspec is fine imo, your choice

gmarler commented 1 year ago

Ok, added tests for when node['rsyslog']['max_message_size']:

Is explicitly set to nil
I explicitly set to '4k'

Let me know if the manner of testing is good for you, and if you want me to add another test for when the directive simply defaults (node['rsyslog']['max_message_size'] isn't set at all).

kitchen-porter commented 1 year ago

Released as: 9.2.0