Lwrp only notifies when changed

sous-chefs / rsyslog

Development repository for the rsyslog cookbook

https://supermarket.chef.io/cookbooks/rsyslog

Apache License 2.0

65 stars 199 forks source link

Lwrp only notifies when changed #69

Closed josacar closed 9 years ago

josacar commented 9 years ago

Make file_input LWRP only notify when underlying template resource changes, use use_inline_resources.

This also includes:

Do not check Guardfile in rubocop
Fix FC017 error in notifying syntax
Change vendor/** to vendor/**/* to remove a deprecation
Fix ChefSpec tests and include it in travis and default tasks

jtimberman commented 9 years ago

We should extract that to a helper method that returns that service object.

josacar commented 9 years ago

@jtimberman pushed, I also added a test-kitchen test to ensure that works. I can do a rebase when ready to clean commits up. Thanks for your feedback and help.

josacar commented 9 years ago

I was wondering to convert input_file LWRP to HWRP, but I think it's not needed right now. I checked some Chef cookbooks to try to follow Chef's style guidelines, I hope I did it right .

josacar commented 9 years ago

@jtimberman How does it looks like right now?

tas50 commented 9 years ago

Merging to fix https://github.com/opscode-cookbooks/rsyslog/issues/77