Validate the config file using `rsyslogd -N 1` whenever a config change is made

sous-chefs / rsyslog

Development repository for the rsyslog cookbook

https://supermarket.chef.io/cookbooks/rsyslog

Apache License 2.0

65 stars 199 forks source link

Validate the config file using `rsyslogd -N 1` whenever a config change is made #76

Closed eherot closed 8 years ago

eherot commented 9 years ago

Right now if an error is made somewhere in the configuration, rsyslog fails silently on restart. This should cause it to throw an error on convergence.

Potential pitfall: Validation is only performed on file update, but the update happens regardless of whether the validation succeeds. Consequently the convergence will only fail the first time after an error is introduced. Thoughts?

eherot commented 9 years ago

Also note that kitchen test fails now with this change because some things in the current setup actually fail validation.

tas50 commented 9 years ago

If you could rebase this to the current changes I'll get it merged it. This would be very useful.

iennae commented 8 years ago

@eherot Thanks for your contribution. I've rebased, checked and merged with PR #112.