search

sous-chefs / ruby_rbenv

Development repository for the ruby_rbenv cookbook
https://supermarket.chef.io/cookbooks/ruby_rbenv
Apache License 2.0
331 stars 251 forks source link

refactored user_install.rb resources group property #243

Closed Doltair closed 5 years ago

Doltair commented 5 years ago

Description

Fixing ruby_rbenv cookbook and will open PR to the source author changing custom resource

From:

property :group,        String, default: lazy { user }

To:

property :group,        String

Issues Resolved

       49:   git new_resource.user_prefix do
       50:     repository new_resource.git_url
       51:     reference new_resource.git_ref
       52:     action :checkout if new_resource.update_rbenv == false
       53:     user new_resource.user
       54:     group new_resource.group <=== not working if custom group is specified
       55:     notifies :run, 'ruby_block[Add rbenv to PATH]', :immediately
       56:   end
       57:

This change is Reviewable

kitchen-porter commented 5 years ago
1 Error
:no_entry_sign: Please include a CHANGELOG entry.
1 Warning
:warning: This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

damacus commented 5 years ago

This just removes the default right now. I'm going to put some tests together (unless you get there first!) to prove this is the case.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.