Clean up foodcritic errors.

sous-chefs / rundeck

Development repository for the rundeck cookbook

https://supermarket.chef.io/cookbooks/rundeck

Apache License 2.0

46 stars 68 forks source link

Clean up foodcritic errors. #191

Closed mrala closed 5 years ago

mrala commented 6 years ago

Resolves #190

Remove deprecated use_inline_resources syntax
Use build_essential resource instead of cookbook
[ ] All tests pass.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable

tas50 commented 6 years ago

You want to keep the depends on build-essential cookbook and still use the resource. A long time ago we added a resource to the build-essential cookbook, but not many people used it. In Chef 14 we shipped that within chef-client. The first step in updating things is to move people over to the resource, but still depend on the cookbook.

mrala commented 6 years ago

@tas50 gotcha, thanks for the info.

mrala commented 6 years ago

Trying to figure out why unit tests are still failing...

damacus commented 5 years ago

Closing this down now, thanks very much for taking the time on this PR!

@PowerSchill's done some great work that's now in master.