"-" and "_" are valid characters in module names - Githubissues

sous-chefs / selinux

Development repository for the selinux cookbook

https://supermarket.chef.io/cookbooks/selinux

Apache License 2.0

58 stars 70 forks source link

"-" and "_" are valid characters in module names #61

Closed jimwise closed 3 years ago

jimwise commented 5 years ago

Without this change, modules with "_" or "-" in their name will have their name truncated on parsing, resulting in either

a.) always rebuilding (since no module with the truncated name is present), breaking idempotency

b.) never rebuilding (since the truncated name matches an existing module), breaking installation

Signed-off-by: Jim Wise jwise@draga.com

Description

Fixes idempotency and installation for modules with "-" or "_" in their name.

Issues Resolved

Check List

[X] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[X] New functionality includes testing.
[N/A] New functionality has been documented in the README if applicable
[?] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

bmhughes commented 3 years ago

Implemented in #74