sous-chefs / selinux

Development repository for the selinux cookbook
https://supermarket.chef.io/cookbooks/selinux
Apache License 2.0
58 stars 70 forks source link

Import resources from selinux_policy #79

Closed detjensrobert closed 3 years ago

detjensrobert commented 3 years ago

Description

Imports resources from the selinux_policy cookbook so we don't have duplicated cookbooks.

The new resources were redone to use native shell_out! instead of execute resources.

Also:

Issues Resolved

(none)

Check List

:warning: The kitchenConverge module fails to install on Debian/Ubuntu locally, but seems to be fine in GH CI :shrug:


Cookbook migration

The merged resources have the same properties and are drop-in (with a rename), except the following:

ramereth commented 3 years ago

I really think it would be nice for users to add the resource names that were used in selinux_policy as a provides so that folks can more easily migrate to this cookbook. At least selinux_port seems like a good candidate as the properties do not change. What issues would we run into with the other resources we're copying over?

detjensrobert commented 3 years ago

Aside from the deprecated :addormodify action, the properties on the migrated resources are the same. The main difference in the overlapping resources is with module and boolean. boolean's persistence was moved to a property toggle instead of an action, and module works somewhat differently internally but the main properties are the same.

Providing resource names from the other cookbook seems somewhat unnecessary, since the resource has changed and there are some other (minor) changes needed with the deprecations.

kitchen-porter commented 3 years ago

Released as: 6.0.0