search

sous-chefs / users

Development repository for the users cookbook
https://supermarket.chef.io/cookbooks/users
Apache License 2.0
138 stars 217 forks source link

Allow to override base_homedir in users_manage #100

Closed kesor closed 8 years ago

chef-supermarket commented 9 years ago

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

nkadel-skyhook commented 8 years ago

Shouldn't this be accompanied by documentation changes?

iennae commented 8 years ago

This seems like a great option to add to the resource. Since it's been almost a year since creation, I'm not going to assume that you are still using this though. This PR requires a few things in order to get accepted.

  1. You need to sign the CLA in order for us to accept the change.
  2. Update your repository to the current state of the repo.
  3. Update the README to include information about the home_basedir and example usage.

Extra bonus points if you also:

  1. create unit and integration tests for this.

If you do the first 3, I will get this into a release quickly as it is a very straightforward change with little impact.

Thanks!

Jennifer

iennae commented 8 years ago

Closing as no response. If you want to take a look at my previous comment, and implement the changes suggested to reopen this totally open to your contributions. Thank you!