Fix user creation on mac_os_x

sous-chefs / users

Development repository for the users cookbook

https://supermarket.chef.io/cookbooks/users

Apache License 2.0

138 stars 217 forks source link

Fix user creation on mac_os_x #394

Closed lcorn closed 7 years ago

lcorn commented 7 years ago

Description

Fixed user creation and removing on Mac OS X. Also fixes situation when we have user and group with the same name.

Issues Resolved

Issue #313

cheeseplus commented 7 years ago

This looks good aside from the few style rules it's getting hung up on - if you could resolve those or let us know if they are required (double negation) then we can get this merged.

lcorn commented 7 years ago

I've reduced some mess with commits. Also I've fixed style rules.

I think that double negation isn't a big issue. This functions from osx_helper.rb were taken from official chef repo. https://github.com/chef/chef/blob/26213aedd56486161c6f9d5d16bc40a258a4c6db/lib/chef/provider/group/dscl.rb#L92

tas50 commented 7 years ago

Thanks for getting this put together. I'll exclude the rubocop warnings for now so we can get this shipped.