sous-chefs / users

Development repository for the users cookbook
https://supermarket.chef.io/cookbooks/users
Apache License 2.0
138 stars 218 forks source link

add support for manage_home = false #404

Closed Raboo closed 6 years ago

Raboo commented 7 years ago

add support for manage_home = false.

Description

Trying to add users without copying /etc/skel.

Issues Resolved

403

Check List

Raboo commented 7 years ago

Ok, did try to run the tests

Testing currently fails on freebsd.

     ∅  shell should eq "/bin/bash"

     expected: "/bin/bash"
          got: "/bin/sh"

     (compared using ==)

macosx failed cause I didn't have vmware_fusion installed, so osx wasn't tested.

opensuse failed cause the groups wasn't sorted

     ∅  groups should eq ["test_user", "testgroup", "nfsgroup"]

     expected: ["test_user", "testgroup", "nfsgroup"]
          got: ["users", "testgroup", "nfsgroup"]

     (compared using ==)

Should perhaps be a .sort somewhere so the groups are always sorted.

This is the exception output of chef exec kitchen test

>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: 5 actions failed.
>>>>>>     Verify failed on instance <default-freebsd-103>.  Please see .kitchen/logs/default-freebsd-103.log for more details
>>>>>>     Verify failed on instance <default-freebsd-110>.  Please see .kitchen/logs/default-freebsd-110.log for more details
>>>>>>     Failed to complete #create action: [Expected process to exit with [0], but received '1'
---- Begin output of vagrant up --no-provision --provider vmware_fusion ----
STDOUT:
STDERR: The provider 'vmware_fusion' could not be found, but was requested to
back the machine 'default'. Please use a provider that exists.
---- End output of vagrant up --no-provision --provider vmware_fusion ----
Ran vagrant up --no-provision --provider vmware_fusion returned 1] on default-macosx-1011
>>>>>>     Verify failed on instance <default-opensuse-132>.  Please see .kitchen/logs/default-opensuse-132.log for more details
>>>>>>     Verify failed on instance <default-opensuse-leap-422>.  Please see .kitchen/logs/default-opensuse-leap-422.log for more details
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration

Also ran delivery local all

Chef Delivery
Running Every Stage
Running Lint Phase
Inspecting 15 files
...............

15 files inspected, no offenses detected
Running Syntax Phase
FC003: Check whether you are running with chef server before using server-specific features: ./resources/manage.rb:36
FC003: Check whether you are running with chef server before using server-specific features: ./resources/manage.rb:174
FC005: Avoid repetition of resource declarations: ./spec/recipes/home_dir_spec.rb:48
FC011: Missing README in markdown format: spec/README.md:1
FC016: LWRP does not declare a default action: ./resources/manage.rb:1
FC031: Cookbook without metadata file: spec/metadata.rb:1
FC045: Metadata does not contain cookbook name: spec/metadata.rb:1
Running Unit Phase
/Users/raboo/.rvm/rubies/ruby-2.2.0/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- chefspec (LoadError)
    from /Users/raboo/.rvm/rubies/ruby-2.2.0/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
    from /Users/raboo/repos/users/spec/spec_helper.rb:1:in `<top (required)>'
    from /Users/raboo/.rvm/rubies/ruby-2.2.0/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
    from /Users/raboo/.rvm/rubies/ruby-2.2.0/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
    from /Users/raboo/repos/users/spec/recipes/home_dir_spec.rb:1:in `<top (required)>'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/gems/rspec-core-3.5.1/lib/rspec/core/configuration.rb:1435:in `load'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/gems/rspec-core-3.5.1/lib/rspec/core/configuration.rb:1435:in `block in load_spec_files'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/gems/rspec-core-3.5.1/lib/rspec/core/configuration.rb:1433:in `each'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/gems/rspec-core-3.5.1/lib/rspec/core/configuration.rb:1433:in `load_spec_files'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/gems/rspec-core-3.5.1/lib/rspec/core/runner.rb:100:in `setup'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/gems/rspec-core-3.5.1/lib/rspec/core/runner.rb:86:in `run'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/gems/rspec-core-3.5.1/lib/rspec/core/runner.rb:71:in `run'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/gems/rspec-core-3.5.1/lib/rspec/core/runner.rb:45:in `invoke'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/gems/rspec-core-3.5.1/exe/rspec:4:in `<top (required)>'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/bin/rspec:23:in `load'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/bin/rspec:23:in `<main>'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/bin/ruby_executable_hooks:15:in `eval'
    from /Users/raboo/.rvm/gems/ruby-2.2.0/bin/ruby_executable_hooks:15:in `<main>'
Phase failed with exit code (1)!

I followed instructions, so I don't know why chefspec is missing.

How do I proceed from here?

Raboo commented 6 years ago

closing this one as it has stalled..