Add attribute to disable private user group creation for each user

msgarbossa commented 6 years ago

Description

This change adds the upg attribute to allow User Private Groups to be disabled. This cookbook has always enforced User Private Groups (UPG), meaning creation of a private group for each user, but some users of this cookbook may prefer more control over group creation and want to disable UPG. To keep the change non-breaking, the default remains UPG = true. Setting UPG = false will prevent the user's private group from being created and instead set the user's primary group to the first existing group in the groups entry of the data data bag item. This allows the user to exist in multiple groups within a data bag without extra converges on every chef-client run.

Issues Resolved

Resolves #85

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

majormoses commented 6 years ago

@tas50 looks like the error is a transient SSL issue to github can we get a rebuild?

iennae commented 6 years ago

@majormoses error is still showing up.

majormoses commented 6 years ago

Hmm that would seem to indicate that the ca-certs in kitchen are not up to date enough to talk to github. We could try updating those commands required for each platform in intermediate_instructions another option is to add one of the (cacerts|ca-certs) cookbook as a dependency to the test cookbook and see if we can fix that. The tests were failing in master on travis-ci before I added that feature in #410. What about the comment on running the same conditional logic twice?

tas50 commented 6 years ago

I'm going to close this out since the change has diverged from master and we haven't heard back about a rebase. If this is still something you want to get merged in please open a new PR against the current master state.

sous-chefs / users