sous-chefs / users

Development repository for the users cookbook

https://supermarket.chef.io/cookbooks/users

Apache License 2.0

138 stars 218 forks source link

check if uid is set before calling .to_i #447

Closed evandam closed 3 years ago

evandam commented 3 years ago

Description

Check if uid is set for a user before calling to_i to correctly fall back on username.

Issues Resolved

Fixes https://github.com/sous-chefs/users/issues/446

Check List

[ ] All tests pass. See TESTING.md for details.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

frank-m commented 3 years ago

Thanks for the pull request @evandam

Would it be possible to update the changelog with your change? You can put it under Unreleased and the automation will take care of it when merging :)

frank-m commented 3 years ago

Actually, I found the issue in a few more places. So I have created #449 to fix these issues and add tests to make sure it does not return.

I am closing your pull request as it is superseded.

Thanks again.